[lldb] Increment index of field we're looking for when not an enum #5307
Conversation
|
@swift-ci test |
There was a problem hiding this comment.
Would be good to comment (I assume it's because enums have exactly 1 field?)
Also: should this be !is_enum && field.TR`?
Finally: testcase?
There was a problem hiding this comment.
Would be good to comment (I assume it's because enums have exactly 1 field?)
I think the comment there still applies. If it's an enum and there's no typeref then we don't increment the index, because that's a case without a payload.
Also: should this be !is_enum && field.TR`?
I don't think so? If it's not not an enum we always want to increment the index (given the previous comment), in case it's an enum we wan't to increment only if there's a typeref.
Finally: testcase?
If we merge swiftlang/swift#61081 TestSwiftFoundation.py will catch this. Otherwise I'll have to figure out a way to trigger this behavior.
|
@swift-ci test |
augusto2112
force-pushed
the
increment-not-enum
branch
from
6845aaa to
64fe672
Compare
There was a problem hiding this comment.
At some point we should write an lldbutil function that calls FileCheck on a text file...
|
@swift-ci test |
2 similar comments
|
Targeted branch is |
|
Oh! So that's why! Thanks @shahmishal! |
augusto2112
changed the base branch from
cached/stable/20220421
to
stable/20220421
2 similar comments
Imported types also don't have typerefs, so we have to increment the index of the field we're looking for in that case.
augusto2112
force-pushed
the
increment-not-enum
branch
from
64fe672 to
3add4d9
Compare
Imported types also don't have typerefs, so we have to increment the index of the field we're looking for in that case.