[lldb] Add tests for Swift class with C++ ivars and STL types in Swift #6401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
| ifeq "$(SWIFT_CXX_INTEROP)" "1" | ||
| CXXFLAGS += -std=c++17 | ||
| else | ||
| CXXFLAGS += -std=c++11 |
There was a problem hiding this comment.
@Michael137 Could we generally bump this on llvm.org for all tests by default?
There was a problem hiding this comment.
Think it could be worthwhile. Easy enough to test whether anything breaks
We'd just have to be careful with the buildbot matrix for older compilers. But I think Clang 7.0 is the oldest version that supports libc++ with -std=c++17 properly, which is also the oldest clang version on the buildbots, so it might be time to make the switch.
.../API/lang/swift/cxx_interop/forward/swift-class-with-cxx-ivars/TestSwiftClassWithCxxIvars.py
Outdated
Show resolved
Hide resolved
lldb/test/API/lang/swift/cxx_interop/forward/test-stl-types/TestSTLTypes.py
Outdated
Show resolved
Hide resolved
augusto2112
force-pushed
the
test-ivars-and-stl-interop
branch
from
fa83d10 to
7975245
Compare
|
@swift-ci test |
augusto2112
force-pushed
the
test-ivars-and-stl-interop
branch
from
7975245 to
9278065
Compare
|
@swift-ci test |
augusto2112
force-pushed
the
test-ivars-and-stl-interop
branch
from
9278065 to
c1fc782
Compare
|
@swift-ci test |
augusto2112
force-pushed
the
test-ivars-and-stl-interop
branch
from
c1fc782 to
dc33a00
Compare
|
@swift-ci test |
augusto2112
force-pushed
the
test-ivars-and-stl-interop
branch
from
dc33a00 to
c7d8dec
Compare
|
@swift-ci test |
augusto2112
force-pushed
the
test-ivars-and-stl-interop
branch
from
c7d8dec to
fd8026d
Compare
|
@swift-ci test |
augusto2112
force-pushed
the
test-ivars-and-stl-interop
branch
from
fd8026d to
a5113a5
Compare
|
@swift-ci test |
augusto2112
force-pushed
the
test-ivars-and-stl-interop
branch
from
a5113a5 to
4ef829e
Compare
|
@swift-ci test |
augusto2112
force-pushed
the
test-ivars-and-stl-interop
branch
from
4ef829e to
cc8fcdc
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://100284870