Implement private discriminator lookup for debug map symbol files. #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that this wasn;t implemented at all and the existing tests were working by coincidence because RegisterAllVariables() also injects local copies of global variables, which bypasses the discriminator matching. After properly implementing discriminator support a couple of additional bugs got uncovered which should all be fixed by this commit and the matching Swift compiler update to serialize the isTopLevelGlobal bit on VarDecls. <rdar://problem/58846302>
|
test with swiftlang/swift#29489 |
|
@swift-ci test |
|
test with swiftlang/swift#29489 |
3 similar comments
|
test with swiftlang/swift#29489 |
|
test with swiftlang/swift#29489 |
|
test with swiftlang/swift#29489 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that this wasn;t implemented at all and the existing
tests were working by coincidence because RegisterAllVariables() also
injects local copies of global variables, which bypasses the
discriminator matching. After properly implementing discriminator
support a couple of additional bugs got uncovered which should all be
fixed by this commit and the matching Swift compiler update to
serialize the isTopLevelGlobal bit on VarDecls.
rdar://problem/58846302