[cherry-pick][swift/release/5.9] [lldb][DataFormatter] Add std::ranges::ref_view formatter #6867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
Michael137
force-pushed
the
bugfix/ref-view-formatter-lldb-to-5.9
branch
from
c092113 to
b6a82c6
Compare
|
@swift-ci test |
|
@swift-ci Please test Windows platform |
Michael137
force-pushed
the
bugfix/ref-view-formatter-lldb-to-5.9
branch
from
b6a82c6 to
5e8cf3b
Compare
|
@swift-ci test |
Michael137
force-pushed
the
bugfix/ref-view-formatter-lldb-to-5.9
branch
from
5e8cf3b to
0bf28e8
Compare
|
@swift-ci test |
This patch adds a formatter for `std::ranges::ref_view<T>`. It simply holds a `T*`, so all this formatter does is dereference this pointer and format it as `T` would be. **Testing** * Added API tests Differential Revision: https://reviews.llvm.org/D138558 (cherry picked from commit 77b2205)
Michael137
force-pushed
the
bugfix/ref-view-formatter-lldb-to-5.9
branch
from
0bf28e8 to
2ed2d24
Compare
Since the LLDB testing infrastructure for swift.ci doesn't currently allow running API tests against newly built libcxx, there is no way for us to guarantee that the necessary `ranges` headers will be available. So disable the test until the infra is fixed.
|
@swift-ci test |
|
@swift-ci Please test Windows platform |
adrian-prantl
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a formatter for
std::ranges::ref_view<T>.It simply holds a
T*, so all this formatter does is dereferencethis pointer and format it as
Twould be.Testing
Differential Revision: https://reviews.llvm.org/D138558
(cherry picked from commit 77b2205)