Skip to content

[Test][ObjC] Fix objc-asm-attribute-test.m. #7625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

al45tair
Copy link

The release/5.10 branch doesn't have the change that makes LLVM use plain ptr everywhere, so we need the whole getelementptr dance in the output we're inspecting in this test.

rdar://117009854

@al45tair
Copy link
Author

The PR that added the lines to the test was #7568.

@al45tair al45tair changed the title [Test][ObjC] Fix objc-adm-attribute-test.m. [Test][ObjC] Fix objc-asm-attribute-test.m. Oct 16, 2023
The release/5.10 branch doesn't have the change that makes LLVM use plain
`ptr` everywhere, so we need the whole `getelementptr` dance in the output
we're inspecting in this test.

rdar://117009854
@al45tair
Copy link
Author

@swift-ci Please test

@al45tair
Copy link
Author

@swift-ci Please test windows platform

@al45tair al45tair merged commit 00f458a into swiftlang:swift/release/5.10 Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant