[lldb/API] Hoist some of SBFrame logic to lldb_private::StackFrame (NFC) #9610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FC) (llvm#116298) This patch moves some of the logic implemented in the SBFrame APIs to the lldb_private::StackFrame class so it can be re-used elsewhere. Signed-off-by: Med Ismail Bennani <ismail@bennani.ma> (cherry picked from commit 9c7701f)
…lvm#116300) This patch is a follow-up to 9c7701f and adds extra-null checks before dereferencing the inlined_info pointer. Signed-off-by: Med Ismail Bennani <ismail@bennani.ma> (cherry picked from commit 1857d29)
…ame (NFC) This patch moves the logic for IsSwiftThunk and GetLanguageSpecificData from SBFrame to the lldb_private::StackFrame class so it can be re-used elsewhere. Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>
|
@swift-ci test |
bulbazord
approved these changes
Nov 15, 2024
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves some of the logic implemented in the SBFrame APIs to
the lldb_private::StackFrame class so it can be re-used elsewhere.
rdar://139026548
Signed-off-by: Med Ismail Bennani ismail@bennani.ma