Make the build/logMessage conform to the BSP spec
#2279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci Please test |
bnbarham
approved these changes
Sep 2, 2025
|
|
||
| /// The request id that originated this notification. | ||
| /// The originId field helps clients know which request originated a notification in case several requests are handled by the | ||
| /// client at the same time. It will only be populated if the client defined it in the request that triggered this notification. */ |
There was a problem hiding this comment.
Suggested change
| /// client at the same time. It will only be populated if the client defined it in the request that triggered this notification. */ | |
| /// client at the same time. It will only be populated if the client defined it in the request that triggered this notification. |
When I added the log structure to `build/logMessage` in swiftlang#2022 I must have assumed that the entire BSP notifciation was an extension defined by SourceKit-LSP and didn’t realized that this was actually a change that made the notification non-compliant with BSP. Change it up a little bit to make it compliant again.
ahoppen
force-pushed
the
log-bsp-compliant
branch
from
caf30e2 to
d734331
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added the log structure to
build/logMessagein #2022 I must have assumed that the entire BSP notifciation was an extension defined by SourceKit-LSP and didn’t realized that this was actually a change that made the notification non-compliant with BSP. Change it up a little bit to make it compliant again.