Skip to content

chore: remove unused field #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025
Merged

chore: remove unused field #188

merged 2 commits into from
Feb 18, 2025

Conversation

MojtabaHs
Copy link
Contributor

This fix may require additional attention as it involves a raw string input and may also need corresponding adjustments on the source side. Please run the @swift-ci test and let me know if deeper changes are necessary.
Thanks!

This may need extra attention since it is parsing a raw string
@neonichu
Copy link
Collaborator

Hm, as far as I can tell, neither UserVisisbleName nor UserVisibleName are actually used by any specs at this time.

@MojtabaHs
Copy link
Contributor Author

Hm, as far as I can tell, neither UserVisisbleName nor UserVisibleName are actually used by any specs at this time.

This is beyond my knowledge of this repo 😃 but I see a FIXME above this code saying: Eliminate any of these fields which are unused.

@MojtabaHs MojtabaHs changed the title fix!: typo in the UserVisibleName chore: remove unused field Feb 18, 2025
@jakepetroules jakepetroules enabled auto-merge (squash) February 18, 2025 21:47
@jakepetroules
Copy link
Collaborator

@swift-ci test

@jakepetroules jakepetroules merged commit 0fca2ee into swiftlang:main Feb 18, 2025
1 of 3 checks passed
@MojtabaHs MojtabaHs deleted the specs2 branch March 12, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants