Upgrade SWBUtil to Swift 6 #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
requested review from
aciidgh,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
|
@swift-ci test |
neonichu
approved these changes
Aug 27, 2025
jakepetroules
force-pushed
the
eng/PR-swbutil-swift6
branch
from
5e86832 to
54edb9b
Compare
This also required a bit of a rethink of the plugin manager now that actor isolation checking is enabled for types defined in SWBUtil. We introduce a new plugin manager type and cover protocol representing an immutable view of the plugin loading state. This is constructed from the mutable plugin manager just prior to core initialization, ensuring Core and everything underneath it have a completely immutable view of the plugin loading state, without having to worry about async/actors, making all of the extension points accessible from synchronous nonisolated code.
jakepetroules
force-pushed
the
eng/PR-swbutil-swift6
branch
from
54edb9b to
e80c447
Compare
|
@swift-ci test |
|
Heads-up, this broke our CI: I believe Swift CI will soon break too on this build: https://ci-external.swift.org/job/swift-main-windows-toolchain/1554/ |
Steelskin
reviewed
Aug 28, 2025
| extern FILE * const swb_stdout(); | ||
| extern FILE * const swb_stderr(); | ||
|
|
||
| FILE * const swb_stdout() { |
There was a problem hiding this comment.
I believe this and swb_stderr() below need to be marked with __declspec(dllexport) on Windows.
There was a problem hiding this comment.
#751 might fix it, I'll run it on our CI to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also required a bit of a rethink of the plugin manager now that actor isolation checking is enabled for types defined in SWBUtil. We introduce a new plugin manager type and cover protocol representing an immutable view of the plugin loading state. This is constructed from the mutable plugin manager just prior to core initialization, ensuring Core and everything underneath it have a completely immutable view of the plugin loading state, without having to worry about async/actors, making all of the extension points accessible from synchronous nonisolated code.