Add API to allow clients to manage build description lifecycle #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
jonathanpenn,
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu and
aciidgh
as code owners
|
@swift-ci test |
owenv
force-pushed
the
owenv/description-refcounting
branch
from
2408d9a to
3432338
Compare
|
@swift-ci test |
|
lgtm. Just to double check, this is ultimately only going to be a signal to the in-memory cache, right? |
jonathanpenn
approved these changes
Sep 14, 2025
jonathanpenn
approved these changes
Sep 14, 2025
|
@jonathanpenn this is a guarantee a build description will never be destroyed rather than a signal it shouldn't be. But it's opt-in, because it's designed primarily for usage in long-lived build servers |
owenv
force-pushed
the
owenv/description-refcounting
branch
from
3432338 to
a40650b
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
jakepetroules
approved these changes
Sep 15, 2025
neonichu
approved these changes
Sep 15, 2025
Fix typo Co-authored-by: Jake Petroules <jake.petroules@apple.com>
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic optional refcounting for build descriptions so that clients making repeated requests can choose to manually manage their lifecycle.