Move a build setting from swiftPM to swift-build #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was some code in swiftPM that would set CLANG_COVERAGE_MAPPING_LINKER_ARGS = NO if the mach_o_type was "mh_object" due to some duplicate symbol problems, this change moves it down to the objfile product type spec where it belongs.
daveinglis
requested review from
aciidgh,
jakepetroules,
mhrawdon,
mirza-garibovic,
neonichu and
owenv
as code owners
owenv
approved these changes
Sep 15, 2025
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some code in swiftPM that would set
CLANG_COVERAGE_MAPPING_LINKER_ARGS = NO if the mach_o_type was "mh_object" due to some duplicate symbol problems, this change moves it down to the objfile product type spec where it belongs.