Keep -target and -isysroot options on the clang command lines, rather than in response files #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhrawdon
requested review from
aciidgh,
jakepetroules,
neonichu and
owenv
as code owners
|
@swift-ci test |
owenv
approved these changes
Oct 2, 2025
jakepetroules
previously requested changes
Oct 2, 2025
… than in response files rdar://161776508
mhrawdon
force-pushed
the
mhrawdon/clang-response-file-target-isysroot
branch
from
45e2ace to
fe9183d
Compare
|
@swift-ci test |
neonichu
approved these changes
Oct 2, 2025
mhrawdon
dismissed
jakepetroules’s stale review
The requested change has been made.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://161776508