FreeBSD: Set TSD to NULL when maximum pthread dtor iterations reached #5273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On FreeBSD, libthr emits debug message to stderr if a TSD is non-null after `PTHREAD_DESTRUCTOR_ITERATIONS` of dtor getting called. Currently, although we skipped setting the TSD to `CF_TSD_BAD_PTR` like other platforms, the TSD still remains non-null after max iterations of dtor calls.
|
@swift-ci test |
etcwilde
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On FreeBSD, libthr emits debug message to stderr if a TSD is non-null after
PTHREAD_DESTRUCTOR_ITERATIONSof dtor getting called.Currently, although we skipped setting the TSD to
CF_TSD_BAD_PTRlike other platforms, the TSD still remains non-null after max iterations of dtor calls and setting the TSD to NULL explicitly is needed