Skip to content

build: Use new 16 KB page alignment on 64-bit Android #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

build: Use new 16 KB page alignment on 64-bit Android #893

merged 1 commit into from
Aug 11, 2025

Conversation

finagolfin
Copy link
Member

This is passed in separately for libswiftDispatch by build-script.

@finagolfin
Copy link
Member Author

@swift-ci test

@finagolfin
Copy link
Member Author

@compnerd, small Android-only pull, please review.

compnerd
compnerd requested changes Aug 11, 2025
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hoist this to the top level rather than being target specific. I think that this should apply to all the targets that we build.

@finagolfin
Copy link
Member Author

Good point.

@swift-ci test

@finagolfin
Copy link
Member Author

@swift-ci test

@finagolfin finagolfin requested a review from compnerd August 11, 2025 17:37
@finagolfin finagolfin merged commit ed4c2a1 into swiftlang:main Aug 11, 2025
2 checks passed
@finagolfin finagolfin deleted the page branch August 11, 2025 22:16
This was referenced Aug 11, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compnerd compnerd compnerd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@finagolfin @compnerd