Fix missing platforms in declaration fragments #1314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates test assertions to expect iOS + iPadOS + Mac Catalyst when iOS is present in declaration platforms, using Set-based comparisons for order-independent testing. The modified tests are temporarily skipped until the platform expansion functionality is implemented in the next commit.
… fragments Automatically expands iOS to include its fallback platforms (iPadOS and Mac Catalyst) in declaration fragment platform arrays to ensure consistent platform representation. Uses the existing DefaultAvailability.fallbackPlatforms mapping to determine which platforms should be included when a base platform is present. rdar://158142013
RalucaP
force-pushed
the
fix-missing-platforms-in-declaration-fragments
branch
from
3a1efba to
a3a88e7
Compare
RalucaP
requested review from
QuietMisdreavus,
anferbui,
d-ronnqvist and
sofiaromorales
QuietMisdreavus
approved these changes
Oct 7, 2025
|
@swift-ci Please test |
d-ronnqvist
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue: rdar://158142013
Summary
This PR addresses an inconsistency in platform representation within declaration fragments. Previously, when iOS was present in a symbol's platform availability, declaration fragments would only show iOS, while other parts of the system correctly included fallback platforms (iPadOS and Mac Catalyst).
The implementation adds automatic platform expansion using the existing
DefaultAvailability.fallbackPlatformsmapping to ensure consistent platform representation across all documentation outputs.Dependencies
None.
Testing
The functionality can be tested using the provided
Availability.doccsample bundle.Availability.docc.zip
Steps:
swift run docc convert Availability.docc --output-dir /tmp/docc-test-output --emit-digestChecklist
./bin/testscript and it succeeded