[Static SDK] Build clang before running the main build. #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to do this because otherwise libc++ fails to build, since the clang we pick up from the Swift install is an older version than the one libc++ requires (libc++ currently needs Clang 19; we ship Clang 17 with Swift).
|
(I'm still testing this locally, but I think this should fix the problem that we're seeing.) |
`-Werror` is a stupid option; it basically breaks the build whenever a newer compiler adds a new warning that triggers in your code. We don't need it here, so disable it.
|
It turns out that BoringSSL's |
|
This built successfully locally, with the rebranch checkout. |
Comment on lines
+289
to
+290
| run cmake -G Ninja -S ${source_dir}/swift-project/llvm-project/llvm \ | ||
| -B ${build_dir}/host/clang \ |
There was a problem hiding this comment.
Why does this work with the source dir being llvm-project/llvm instead of llvm-project/clang?
There was a problem hiding this comment.
It actually doesn't work with the source dir being llvm-project/clang (that's the first thing I tried). Using llvm rather than clang is actually what the instructions here say to do.
shahmishal
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to do this because otherwise libc++ fails to build, since the clang we pick up from the Swift install is an older version than the one libc++ requires (libc++ currently needs Clang 19; we ship Clang 17 with Swift).