SwiftDriver: use clang++ as linker driver with C++ Interop
#1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
CC: @hyp @zoecarver |
|
@swift-ci please test |
This adjusts the linker job construction to switch the linker driver to the C++ compiler driver as the linker driver when C++ interop is enabled. This allows us to ensure that we properly link against the C++ runtime which should be assumed to be needed with C++ interop. This is required for further exploration of C++ interop.
|
@swift-ci please test |
artemcm
reviewed
Feb 28, 2022
There was a problem hiding this comment.
This looks good to me in terms of the changes and being gated on enableExperimentalCxxInterop, but I'd really like this PR to get a review from @hyp or @zoecarver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the linker job construction to switch the linker driver to
the C++ compiler driver as the linker driver when C++ interop is
enabled. This allows us to ensure that we properly link against the C++
runtime which should be assumed to be needed with C++ interop. This is
required for further exploration of C++ interop.