Mostly explicit import tools-support-core APIs #1176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
CC: @CodaFi |
artemcm
reviewed
Sep 9, 2022
| import SwiftOptions | ||
|
|
||
| import class Dispatch.DispatchQueue | ||
|
|
||
| import TSCBasic // <<< |
There was a problem hiding this comment.
Guessing this can be removed now. :)
There was a problem hiding this comment.
Afraid not :-(. The import TSCBasic // <<< instances are all importing the module as I couldn't figure out how to import the <<< operator from TSC. If that is possible, I'd be happy to go through and remove the instances.
|
@swift-ci please test |
|
@swift-ci please test |
Switch to explicitly importing the tools-support-core API surface to identify what we are depending on. This will help ween swift-driver off of swift-tools-support-core in the long run.
|
@swift-ci please test |
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Sep 12, 2022
There was a race between swiftlang#1174 and swiftlang#1176 which removed an import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to explicitly importing the tools-support-core API surface to identify what we are depending on. This will help ween swift-driver off of swift-tools-support-core in the long run.