[Embedded] disable using -lswiftCore for embedded targets
#1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
approved these changes
Oct 23, 2023
artemcm
reviewed
Oct 23, 2023
| } else if staticStdlib { | ||
| linkFilePath = linkFilePath?.appending(component: "static-stdlib-args.lnk") | ||
| } else if embeddedEnabled { | ||
| linkFilePath = nil |
There was a problem hiding this comment.
Could we please add a test that passes the experimental feature flag and makes sure the link command does not contain this?
There was a problem hiding this comment.
finally coming back around to this: are there good examples of these types of tests already present? I did not immediately see any.
… with embedded enabled
|
@swift-ci please test |
|
@swift-ci test windows |
artemcm
approved these changes
Nov 7, 2023
|
Windows error looks unrelated to this PR. |
|
@compnerd it looks like an error in the |
|
Closing in favor of #1516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of the changes made here: swiftlang/swift#69258 to avoid passing
-lswiftCoreto embedded targets.