Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for 5.8 host swift-driver bug #1484

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

hamishknight
Copy link
Contributor

@hamishknight hamishknight commented Nov 13, 2023

A 5.8 swift-driver does not pass along the --sanitize flag to the Clang linker (rdar://107733898). Add this workaround to allow building an ASAN swift-driver with a 5.8 toolchain. This is the swift-driver equivalent to swiftlang/swift#64993.

A 5.8 swift-driver does not pass along the `--sanitize`
flag to the Clang linker (rdar://107733898). Add this
workaround to allow building an ASAN swift-driver with
a 5.8 toolchain.
@hamishknight
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hamishknight

@hamishknight hamishknight merged commit 14226b3 into swiftlang:main Nov 13, 2023
3 checks passed
@hamishknight hamishknight deleted the workaround-5.8 branch November 13, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants