[CMake] Workaround sanitizer flag bug in swift driver #64993
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some versions of the swift driver have a bug where passing `-sanitize=` does not emit the correct `-fsanitize=` flag for the clang link step. Although this is being fixed, we must be able to correctly build with older versions of the swift driver for some period of time. We workaround that issue by explicitly passing the correct `-fsanitize=` argument ourselves. This works around rdar://107733898
|
@swift-ci please test |
etcwilde
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some versions of the swift driver have a bug where passing
-sanitize=does not emit the correct-fsanitize=flag for the clang link step. Although this is being fixed, we must be able to correctly build with older versions of the swift driver for some period of time. We workaround that issue by explicitly passing the correct-fsanitize=argument ourselves.This works around rdar://107733898