Skip to content

Plan swiftinterface job and verify interface job together #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

Plan swiftinterface job and verify interface job together #1849

merged 1 commit into from
Mar 21, 2025

Conversation

cachemeifyoucan
Copy link
Contributor

@cachemeifyoucan cachemeifyoucan commented Mar 21, 2025 •
edited
Loading 

Always plan the job producing swiftinterface and verifying
swiftinterface together. This make sure the swiftinterface exists on
disk or in CAS when verification job is running.

rdar://147501517

artemcm
artemcm reviewed Mar 21, 2025
View reviewed changes
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this broadly makes sense. I can't think of a scenario where we need to wait for the second wave to determine if any kind of post-compile task is needed, but if we find one, we could make that work too.

@cachemeifyoucan
Plan swiftinterface job and verify interface job together
21563e1 
Always plan the job producing swiftinterface and verifying
swiftinterface together. This make sure the swiftinterface exists on
disk or in CAS when verification job is running.

rdar://147501517
@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-planning-swiftinterface-verification branch from b8096c4 to 21563e1 Compare March 21, 2025 17:09
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

@cachemeifyoucan cachemeifyoucan merged commit 60522e2 into swiftlang:main Mar 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenv owenv owenv approved these changes

@artemcm artemcm artemcm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cachemeifyoucan @owenv @artemcm