Specify -swift-version in tests that emit swiftinterfaces
#1985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
swiftlang/swift#84244 introduces the requirement that `swift-frontend` jobs emitting a swiftinterface must explicitly specify either `-language-mode` or `-swift-version` to avoid mis-compilation of the interface. Add the necessary arguments to various tests that form their own `swift-frontend` invocations.
tshortli
force-pushed
the
swift-version-required-when-emitting-interfaces
branch
from
fe2e23d to
6f569c3
Compare
|
@swift-ci please test |
artemcm
approved these changes
Sep 13, 2025
|
@swift-ci please test Windows |
tshortli
deleted the
swift-version-required-when-emitting-interfaces
branch
tshortli
added a commit
to tshortli/swift-driver
that referenced
this pull request
Sep 13, 2025
swiftlang#1985 missed a test suite where `-swift-version` needs to be specified explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swiftlang/swift#84244 introduces the requirement that
swift-frontendjobs emitting a swiftinterface must explicitly specify either-language-modeor-swift-versionto avoid mis-compilation of the interface. Add the necessary arguments to various tests that form their ownswift-frontendinvocations.