[Incremental] Fix fingerprint integration bug, add a test, and add debugging affordances. #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
rdar://74513210 |
|
@swift-ci please test |
CodaFi
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When integrating a node where the only change is its fingerprint, it's critical to set the fingerprint of the integrated-to node on the module dependency graph to match the node being integrated. That way, if its fingerprint changes back and it gets integrated again, the change will be noticed.
The above was not happening. This PR adds a test case, fixes the bug, adds a nice
descriptionto source file dependency nodes (to aid in debugging), and also adds a check to ensure that a graph is serializable.