Skip to content

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Feb 19, 2021

We need to ensure that we terminate (SIGINT) the running compiler processes without emitting an error that those processes got terminated, and allow the driver to continue execution so that it is able to emit parseable-output which communicates that the terminated compiler jobs were interrupted.

Resolves rdar://74527749

…cesses without emitting an error that those processes got terminated, and allow the driver to continue execution so that it is able to emit parseable-output which communicates that the terminated compiler jobs were interrupted.

Resolves rdar://74527749
@artemcm artemcm changed the title Experiment with interrupting compiler invocations in the interrupt handler and exiting gracefully Interrupt handler: terminate (SIGINT) running compiler processes and allow the driver to exit gracefully. Feb 19, 2021
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@artemcm
Copy link
Contributor Author

artemcm commented Feb 19, 2021

@swift-ci please test

@akyrtzi
Copy link
Contributor

akyrtzi commented Feb 19, 2021

Yay, cancellation that stops the compiler as intended, nice! 🎉

@artemcm artemcm merged commit 5dbed2e into swiftlang:main Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants