Add @_effects(readnone) to string-based Regex inits
#824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't seem like regex instantiation is being hoisted out of loops, which means that both the parsing (which happens at runtime) and compilation (which happens on first use) are being lost for string-based and possibly literal regexes. This may address the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't seem like regex instantiation is being hoisted out of loops, which means that both the parsing (which happens at runtime) and compilation (which happens on first use) are being lost for string-based and possibly literal regexes. This may address the issue.
There are at least two other initializers that could/should have this attribute (1 2), but adding it causes a compiler crash.