[perf] Create a flattened representation of DSLTree
#831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements bytecode generation from a DSLList instead of a DSLTree. The change includes tests that all regex patterns in the `MatchTests` file produce the exact same bytecode from a list as from a tree.
This likely involves an increase in compilation time, since the list needs to be generated from the tree before compiling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shared
DSLTreetype that is used to store the pre-compilation regex pattern is an indirect enumeration that has arbitrary nesting/recursion. This design makes it challenging both to reference different parts of the tree and to manipulate the tree during compilation for pre- and mid-compilation optimizations.This change introduces a
DSLListtype that stores a pre-order traversal of the tree in an array, and an alternate bytecode generation path that consumes theDSLListinstead of recursing over theDSLTree, with tests that the generated bytecode is identical between the two structures.Still to do (note that compilation time will worsen until these are complete):
DSLListdirectly from parsing/instantiationDSLTreerepresentation