Source locations for alternation pipes and char class ranges #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
force-pushed
the
time-and-place
branch
from
82336a5 to
9c4cbba
Compare
Including a couple of test cases that make sure we have correct source ranges for them, as a later commit will change how we compute their source range.
hamishknight
force-pushed
the
time-and-place
branch
from
9c4cbba to
bdeec8e
Compare
|
@swift-ci please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add source location info to the AST for alternation pipes, and for the
-character in custom char class ranges. In addition, add some extra test cases for alternations, including some that test the expected source locations are parsed.