Skip to content

Make language checks pass on CI #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2025
Merged

Make language checks pass on CI #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2ec998
Make language checks pass in `dlmalloc.c`
MaxDesiatov Apr 7, 2025
d0c36b3
Update upstream_malloc.h
MaxDesiatov Apr 7, 2025
40c7b32
Update pull_request.yml
MaxDesiatov Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
with:
license_header_check_project_name: "Swift"
api_breakage_check_enabled: false
unacceptable_language_check_enabled: false
unacceptable_language_check_enabled: true
license_header_check_enabled: false
broken_symlink_check_enabled: false
format_check_enabled: false
2 changes: 1 addition & 1 deletion Guest/Sources/dlmalloc/src/dlmalloc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// WebAssembly doesn't support shrinking linear memory.
#define MORECORE_CANNOT_TRIM 1

// Disable sanity checks to reduce code size.
// Disable checks to reduce code size.
#define ABORT __builtin_unreachable()

// If threads are enabled, enable support for threads.
Expand Down
3 changes: 1 addition & 2 deletions Guest/Sources/dlmalloc/src/upstream_malloc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3131,8 +3131,7 @@ static int init_mparams(void) {
}
#endif /* WIN32 */

/* Sanity-check configuration:
size_t must be unsigned and as wide as pointer type.
/* size_t must be unsigned and as wide as pointer type.
ints must be at least 4 bytes.
alignment must be at least 8.
Alignment, min chunk size, and page size must all be powers of 2.
Expand Down