Specify the type of decl to rename in AlwaysUseLowerCamelCase. #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the diagnostic message said "rename *variable*..." regardless of the actual type of decl. I have added "function", "enum case", "constant", and "identifier" to the list of supported options. This approach is easily scalable to naming other types of decls as well. I believe this makes the diagnostics more clear and specific, because it was confusing to see a diagnostic that says "rename variable..." that refers to a function's name.
allevato
approved these changes
Aug 18, 2020
allevato
added a commit
to allevato/swift-format
that referenced
this pull request
Sep 17, 2020
Specify the type of decl to rename in AlwaysUseLowerCamelCase.
allevato
added a commit
that referenced
this pull request
Sep 17, 2020
Specify the type of decl to rename in AlwaysUseLowerCamelCase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the diagnostic message said "rename variable..." regardless of the actual type of decl. I have added "function", "enum case", "constant", and "identifier" to the list of supported options. This approach is easily scalable to naming other types of decls as well.
I believe this makes the diagnostics more clear and specific, because it was confusing to see a diagnostic that says "rename variable..." that refers to a function's name.