Fix for newly optional return type of withDigits.
#237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `withDigits` method was updated to return an optional, which causes this to fail to build. I think a nil value here would indicate an error in swift-format's numeric grouping that resulted in an invalid numeric literal. `withDigits` was udpated in a recent swift-syntax change: swiftlang/swift-syntax@94fc5ae#diff-8c79a56bd4eb3d1313169ca412f5e11eL2387
allevato
approved these changes
Oct 7, 2020
aaditya-chandrasekhar
pushed a commit
to val-verde/swift-format
that referenced
this pull request
May 20, 2021
* Set source range for symbols * Adopt Equatable, Comparable, and Hashable in extension on SourceRange * Refactor with sourceRange(using:) helper method * Deprecate sourceLocation Replace existing use of sourceLocation in DCOV extension * Add changelog entries for swiftlang#237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
withDigitsmethod was updated to return an optional, which causes this to fail to build. I think a nil value here would indicate an error in swift-format's numeric grouping that resulted in an invalid numeric literal.withDigitswas udpated in a recent swift-syntax change:swiftlang/swift-syntax@94fc5ae#diff-8c79a56bd4eb3d1313169ca412f5e11eL2387