Adjustments for re-structured effect specifiers #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
commented
Jan 25, 2023
Comment on lines
+1260
to
+1263
| // `FunctionTypeSyntax` used to not use `ReturnClauseSyntax` and had | ||
| // slightly different formatting behavior than the normal | ||
| // `ReturnClauseSyntax`. To maintain the previous formatting behavior, | ||
| // add a special case. |
There was a problem hiding this comment.
@allevato I leave it up to you to decide whether you want to get rid of this special case in a follow-up PR.
allevato
approved these changes
Jan 25, 2023
This was referenced Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion of swiftlang/swift-syntax#1260