Allow exceptions to NoAssignmentInExpressions.
#535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly intended to carve out a really useful exception for testing: `XCTAssertNoThrow(x = try ...)` is quite a bit clearer about intent than `x = try XCTUnwrap(try? ...)` if you need the value `x` later in the test. In an effort to not be *too* specific in this rule, I've opted to make this a configurable list of exceptions that by default contains `XCTAssertNoThrow`. So it only handles function calls right now, but this could be made more flexible in the future.
|
cc @dylansturg |
dylansturg
approved these changes
May 26, 2023
allevato
added a commit
to allevato/swift-format
that referenced
this pull request
Jun 29, 2023
…fixes Allow exceptions to `NoAssignmentInExpressions`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly intended to carve out a really useful exception for testing:
XCTAssertNoThrow(x = try ...)is quite a bit clearer about intent thanx = try XCTUnwrap(try? ...)if you need the valuexlater in the test.In an effort to not be too specific in this rule, I've opted to make this a configurable list of exceptions that by default contains
XCTAssertNoThrow. So it only handles function calls right now, but this could be made more flexible in the future.