WiX: adjust the packaging rules for the SPM runtime #464
+41
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package manager runtime installation adjusted for the split build installs the module with the target triple named thick module format. Adjust the packaging rules to integrate that into the image.
etcwilde
reviewed
Oct 7, 2025
| <ComponentGroupRef Id="package_manager" /> | ||
| <ComponentGroupRef Id="PackageManager" /> | ||
| <!-- Package Manager Manifest Runtime --> | ||
| <ComponentGroupRef Id="CompilerPluginSupport" /> |
There was a problem hiding this comment.
Do we want to prefix these ID's so that it's clear that they are for the manifest runtime and not something else?
There was a problem hiding this comment.
We can, though I'm not sure if that has much value - you wouldn't have these modules duplicated. We could create a ComponentGroup with the modules if you prefer.
| @@ -1,6 +1,13 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
|
|
|||
There was a problem hiding this comment.
I just added that to have some space with the Include to match the other packages
etcwilde
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package manager runtime installation adjusted for the split build installs the module with the target triple named thick module format. Adjust the packaging rules to integrate that into the image.