Update on SwiftJavaDocumentation #372
Open
+21
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
reviewed
Aug 22, 2025
| @@ -38,7 +38,7 @@ Java `native` functions. JavaKit simplifies the type conversions | |||
|
|
|||
| ### JExtract: Java -> Swift | |||
|
|
|||
| SwiftJava's `swift-java jextract` tool automates generating Java bindings from Swift sources. | |||
| SwiftJava's `swift-java jextract` tool automates generating Java bindings to Swift sources. | |||
There was a problem hiding this comment.
This is "from"; we take swift sources as input and generate java; so it's not that the bindings are 'to' swift but that we generate them "from swift sources" 🤔
Maybe this whole sentence needs rewording?
There was a problem hiding this comment.
Ah, ok, I was trying to align with the README line 34
**swift-java jextract**
Is a source generator which will **generate Java bindings to existing Swift libraries**.
How about changing the README to "from" for now, and rewording them both afterwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SupportedFeatures.mdJExtract Java -> Swift section