Fix Build Warnings on Windows #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmittert
commented
Apr 26, 2019
gmittert
force-pushed
the
WindowCleaning
branch
from
ce1643a to
f8e4c1b
Compare
compnerd
reviewed
Apr 27, 2019
gmittert
force-pushed
the
WindowCleaning
branch
4 times, most recently
from
06011f3 to
09e516c
Compare
gmittert
force-pushed
the
WindowCleaning
branch
from
09e516c to
c76813d
Compare
- Properly link against msvcrt by not overriding the /MD in CMAKE_CXX_FLAGS_RELWITHDEBINFO - Rename libllbuild.lib back to llbuild.lib - Rename libllbuildSwift.lib back to llbuildSwift.lib - Disable incremental linking so llbuild.ilk's don't conflict - Set CRT_NONSTDC_NO_DEPRECATE to ignore _strdup warnings
gmittert
force-pushed
the
WindowCleaning
branch
from
c76813d to
bf477a4
Compare
|
Rebased and addressed comments @swift-ci please smoke test |
dmbryson
approved these changes
Aug 13, 2019
finagolfin
reviewed
Aug 24, 2019
| "/EHsc") | ||
| else () | ||
| # Compile with C++14, without RTTI or exceptions. | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-rtti -fno-exceptions") |
There was a problem hiding this comment.
These two flags were left out of the list below, oversight? I ask because this change adds EH functions that breaks linking the Swift package manager on Android. I can always add these flags back specifically for Android, but I wonder if you really wanted to keep them here too.
|
Hrm no, I meant for those not to have any changes, I must have dropped them
by accident while rebasing :( You're welcome to add them back, else, I'll
put up a patch if I don't see one in a few days. Thanks for catching that!
…On Sat., Aug. 24, 2019, 12:42 a.m. buttaface, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CMakeLists.txt
<#475 (comment)>:
> else ()
- # Compile with C++14, without RTTI or exceptions.
- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-rtti -fno-exceptions")
These two flags were left out of the list below, oversight? I ask because
this change adds EH functions that breaks linking the Swift package manager
on Android. I can always add these flags back specifically for Android, but
I wonder if you really wanted to keep them here too.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#475>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQPW6DWR3DRQLR3TFKG4LTQGDQ5RANCNFSM4HIW7N6A>
.
|
finagolfin
added a commit
to finagolfin/swift-llbuild
that referenced
this pull request
Aug 24, 2019
|
Done in #544, thanks for the quick answer. |
jakepetroules
added a commit
to jakepetroules/swift-llbuild
that referenced
this pull request
Aug 30, 2025
…n Windows These were originally added 6 years ago in swiftlang#475 to "Disable incremental linking so llbuild.ilk's don't conflict" because at the time the command line tool and library targets were given the same OUTPUT_NAME, which conflicted. In swiftlang#1005 these targets were given distinct names, so the workaround should no longer be necessary. This helps unblock swiftlang/swift-build#757 because this flag is currently added without regard for the specific compiler driver in use, so the flag might not work based on whether clang-cl.exe or cl.exe vs clang.exe (where it would require a -Xlinker prefix), is used.
jakepetroules
added a commit
that referenced
this pull request
Sep 2, 2025
…n Windows These were originally added 6 years ago in #475 to "Disable incremental linking so llbuild.ilk's don't conflict" because at the time the command line tool and library targets were given the same OUTPUT_NAME, which conflicted. In #1005 these targets were given distinct names, so the workaround should no longer be necessary. This helps unblock swiftlang/swift-build#757 because this flag is currently added without regard for the specific compiler driver in use, so the flag might not work based on whether clang-cl.exe or cl.exe vs clang.exe (where it would require a -Xlinker prefix), is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_CXX_FLAGS_RELWITHDEBINFO