Pass symbol graph options to swift build to customize the output #9124
Conversation
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci test Windows |
|
@swift-ci test Linux |
|
@swift-ci please test |
|
@swift-ci test Windows |
|
@swift-ci please test |
|
@swift-ci test Windows |
cmcgee1024
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri and
daveyc123
as code owners
|
@swift-ci test Windows |
| enableAllTraits: true, | ||
| cacheBuildManifest: false | ||
| ) | ||
| // TODO pass along the various flags as associated values to the symbol graph build output (e.g. includeSPISymbols) |
There was a problem hiding this comment.
nit: is this TODO still applicable with this change?
There was a problem hiding this comment.
Thanks, I'll pull this comment out. It should be done after this PR lands.
| public static func == (lhs: BuildOutput, rhs: BuildOutput) -> Bool { | ||
| switch lhs { | ||
| case .symbolGraph(_): | ||
| return false |
There was a problem hiding this comment.
This seems potentially incorrect, what do we use this Equatable conformance for at the moment?
There was a problem hiding this comment.
It's for the simpler build outputs to see if they are in the array/set. This one has an associated value now that makes it harder to manage. Perhaps this should compare the associated value structure for lhs against rhs, or perhaps there is a better pattern for this.
Remove extraneous comment
|
@swift-ci please test |
|
@swift-ci test Windows |
No description provided.