Prebuild plugin support for swiftbuild build system #9209
Conversation
|
@swift-ci please test |
…le targets in either build system
|
@swift-ci please test |
|
@swift-ci test Windows |
1 similar comment
|
@swift-ci test Windows |
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci test Linux |
|
@swift-ci test macOS |
|
@swift-ci test Linux |
|
@swift-ci test macOS |
|
@swift-ci test Windows |
cmcgee1024
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
daveyc123 and
rconnell9
as code owners
|
|
||
| /// Runs any command plugins associated with the given list of plugin invocation results, | ||
| /// in order, and returns the results of running those prebuild commands. | ||
| fileprivate static func runCommandPlugins( |
There was a problem hiding this comment.
Should this be renamed to something more like "runPrebuildPluginCommands"? I confused it with "command plugins" at first
There was a problem hiding this comment.
This is a variant of another method by the same name in BuildPlan. I was also confused about the naming. Should I rename both?
There was a problem hiding this comment.
IMO yes, I think it's good to clearly differentiate the different plugin types in this code
|
@swift-ci test Windows |
Add prebuild command support for build tool plugins with the swiftbuild build system.
Include a test case that verifies that referring to a tool through context fails in both
major build systems. Test that tools made available through binary artifact dependencies
with an artifact bundle work with both build systems.