Introduce .swift-format and enable linting requirement on PR requests #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCharlesHu
requested review from
cthielen,
parkera,
jakepetroules and
itingliu
jakepetroules
approved these changes
Aug 28, 2025
parkera
reviewed
Aug 28, 2025
| switch self { | ||
| case .string(let string): | ||
| #if os(Windows) | ||
| #if os(Windows) |
There was a problem hiding this comment.
I'm sure we're very inconsistent about this one. I sort of like that #if is aligned differently - it calls out something that changes at a different time (compile time vs run time). Indenting them to me seems a little weird too, because we don't indent the lines under the 'else' like we would have if it were a traditional if { } block.
There was a problem hiding this comment.
Yeah fortunately the only settings are either
#if os(macOS)
var label = ""
#endif
or
#if os(macOS)
var label = ""
#endif
I seem to see we use former more so I decided to go with that
| } | ||
|
|
||
| internal func close() { /* No-op on Darwin */ } | ||
| internal func close() { /* No-op on Darwin */ } |
There was a problem hiding this comment.
Curious why this inserted an additional space.
iCharlesHu
force-pushed
the
charles/introduce-swift-format
branch
from
60f19a9 to
47e015e
Compare
iCharlesHu
force-pushed
the
charles/introduce-swift-format
branch
from
86dcc14 to
7cbb611
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a baseline
.swift-formatand enforce linting when testing.It is NOT a goal of this PR to introduce a finalized styling. Instead, most rules in
.swift-formatare turned off to ensure the diff in this PR is minimal. We will introduce each rule individually with future PRs.