Make Environment keys case-insensitive on Windows #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCharlesHu
reviewed
Sep 4, 2025
jakepetroules
force-pushed
the
eng/PR-environment
branch
from
4a5af15 to
bc74532
Compare
This is how the platform treats them, and helps avoid issues where indexing into an Environment dictionary with the wrong casing fails to return a value. Closes swiftlang#134
jakepetroules
force-pushed
the
eng/PR-environment
branch
from
bc74532 to
13c8403
Compare
iCharlesHu
approved these changes
Sep 5, 2025
|
Thanks!! I'll include this one in 0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how the platform treats them, and helps avoid issues where indexing into an Environment dictionary with the wrong casing fails to return a value.
Closes #134