Skip to content

Move SyntaxClassification to SyntaxBuilder #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2022
Merged

Move SyntaxClassification to SyntaxBuilder #1039

merged 1 commit into from
Dec 5, 2022

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Oct 31, 2022

No description provided.

@kimdv kimdv force-pushed the kimdv/migrate-from-gyb-to-syntax-builder branch 2 times, most recently from 25f9f04 to b6d3acd Compare October 31, 2022 13:29
@kimdv kimdv marked this pull request as ready for review October 31, 2022 13:29
@kimdv kimdv requested a review from ahoppen as a code owner October 31, 2022 13:29
@kimdv kimdv requested a review from fwcd October 31, 2022 13:29
@kimdv
Copy link
Contributor Author

kimdv commented Oct 31, 2022

@swift-ci please test

kimdv
kimdv commented Oct 31, 2022
View reviewed changes
kimdv
kimdv commented Oct 31, 2022
View reviewed changes
kimdv
kimdv commented Oct 31, 2022
View reviewed changes
kimdv
kimdv commented Oct 31, 2022
View reviewed changes
@kimdv kimdv force-pushed the kimdv/migrate-from-gyb-to-syntax-builder branch from b6d3acd to c9b4e4f Compare November 4, 2022 12:40
@kimdv kimdv force-pushed the kimdv/migrate-from-gyb-to-syntax-builder branch from c9b4e4f to c3db216 Compare November 22, 2022 19:44
@kimdv
Copy link
Contributor Author

kimdv commented Nov 22, 2022

@swift-ci please test

ahoppen
ahoppen reviewed Nov 24, 2022
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@kimdv kimdv force-pushed the kimdv/migrate-from-gyb-to-syntax-builder branch from c3db216 to 467729f Compare November 24, 2022 14:40
@kimdv kimdv requested a review from ahoppen November 24, 2022 14:40
@kimdv
Copy link
Contributor Author

kimdv commented Nov 24, 2022

@swift-ci please test

ahoppen
ahoppen approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me 👍

@kimdv
Copy link
Contributor Author

kimdv commented Nov 24, 2022

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Nov 24, 2022

@ahoppen is the CI on vacation ? 🍹

@kimdv
Copy link
Contributor Author

kimdv commented Nov 25, 2022

@swift-ci please test

2 similar comments
@kimdv
Copy link
Contributor Author

kimdv commented Nov 28, 2022

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Nov 28, 2022

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/migrate-from-gyb-to-syntax-builder branch 2 times, most recently from f10044a to 520f5ea Compare November 29, 2022 09:47
@kimdv
Copy link
Contributor Author

kimdv commented Nov 29, 2022

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/migrate-from-gyb-to-syntax-builder branch from 520f5ea to 7915a5b Compare November 29, 2022 10:59
kimdv
kimdv commented Nov 29, 2022
View reviewed changes
@kimdv
Copy link
Contributor Author

kimdv commented Nov 29, 2022

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/migrate-from-gyb-to-syntax-builder branch from 7915a5b to fa185fa Compare November 30, 2022 08:09
@kimdv
Copy link
Contributor Author

kimdv commented Nov 30, 2022

@ahoppen I get the error

Only in /Users/kimdevos/repository/swift/swift-syntax/Sources/SwiftBasicFormat/generated: BasicFormat.swift
FAIL: Gyb-generated files committed to repository do not match generated ones. Please re-generate the gyb-files using the following command, open a PR to the SwiftSyntax project and merge it alongside the main PR.$ swift-syntax/build-script.py generate-source-code --toolchain /path/to/toolchain.xctoolchain/usr

but when I run it locally then I cannot see any changes?

@kimdv kimdv force-pushed the kimdv/migrate-from-gyb-to-syntax-builder branch from fa185fa to b3c9eff Compare November 30, 2022 11:41
@ahoppen
Copy link
Member

ahoppen commented Nov 30, 2022

@swift-ci Please test

@kimdv kimdv force-pushed the kimdv/migrate-from-gyb-to-syntax-builder branch from b3c9eff to 90385e3 Compare December 4, 2022 21:03
@kimdv
Copy link
Contributor Author

kimdv commented Dec 4, 2022

@swift-ci please test

@kimdv kimdv merged commit d65d1bd into swiftlang:main Dec 5, 2022
@kimdv kimdv deleted the kimdv/migrate-from-gyb-to-syntax-builder branch December 5, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@fwcd fwcd Awaiting requested review from fwcd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimdv @ahoppen