Separate SyntaxArena for parsing #1063
Conversation
|
@swift-ci Please test |
|
cc: @jpsim Another optimization, mainly for reducing memory usage. |
rintaro
force-pushed
the
arena-for-parsing
branch
from
30515fe to
c978222
Compare
|
🤦 Forgot to rebase onto up-to-date #1053. Updated. |
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
In terms of memory usage I see a modest improvement in SwiftLint going from 159MB to 152MB. I’ll happily take it! |
| public convenience init() { | ||
| self.init(slabSize: 128) | ||
| } |
There was a problem hiding this comment.
Couldn't we just not use a BumpPtrAllocator for the non-parsing case at all? It's only ever going to have a single allocation, so it still seems wasteful to use the BumpPtrAllocator here.
I love this in general though :)
There was a problem hiding this comment.
It still may allocate multiple nodes. See SyntaxData.replacingSelf(_:arena:) and SyntaxData.replacingChild(_:at:arena:)
By this, single modifier call uses single arena, and creates multiple RawSyntax in it, from the leaf to the root. And I think that is a good thing.
There was a problem hiding this comment.
Okay, fair enough. I think it'd be interesting to compare against allocating as needed but this is okay too 👍
rintaro
force-pushed
the
arena-for-parsing
branch
from
c978222 to
08cb744
Compare
|
@swift-ci Please test |
| /// Parse `source` into as trivia into a list of `RawTriviaPiece` using | ||
| /// `parseTriviaFunction`. |
There was a problem hiding this comment.
| /// Parse `source` into as trivia into a list of `RawTriviaPiece` using | |
| /// `parseTriviaFunction`. | |
| /// Parse `source` into a list of `RawTriviaPiece` using `parseTriviaFunction`. |
Minimize the default memory footprint of SyntaxArena. Introduce ParsingSyntaxArena as a subclass of SyntaxArena optimized for parsing.
rintaro
force-pushed
the
arena-for-parsing
branch
from
08cb744 to
b087dd3
Compare
|
@swift-ci Please test |
Minimize the default memory footprint of
SyntaxArena(for non-parsing). IntroduceParsingSyntaxArenaas a subclass ofSyntaxArenaoptimized for parsing.