[Refactor] Add a refactor action to replace "some" parameters with generics #1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nerics.
SE-0341 introduced opaque parameter declarations, which are syntactic
sugar for introducing a generic parameter that is only used once in
the signature of the type. Provide a refactoring action that replaces
all each use of an opaque parameter declarations in a declaration, e.g.,
func lazyConcatenate<T> {
_ sequence1: some Sequence<T>, _ sequence2: some Sequence<T>
) -> some Sequence<T> { ... }
with a newly-created generic parameter, so the end result is
equivalent but works with early compilers:
func lazyConcatenate<T, T1: Sequence<T>, T2: Sequence<T>> {
_ sequence1: T1, T2
) -> some Sequence<T> { ... }
|
@swift-ci please test |
bnbarham
approved these changes
Nov 14, 2022
|
@swift-ci please test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SE-0341 introduced opaque parameter declarations, which are syntactic sugar for introducing a generic parameter that is only used once in the signature of the type. Provide a refactoring action that replaces all each use of an opaque parameter declarations in a declaration, e.g.,
with a newly-created generic parameter, so the end result is equivalent but works with early compilers: