[CMake] Rework build and installation of all swift-syntax modules #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a lot of CMake code repeated across the various libraries. Consolidate that into a new `add_swift_host_library` and use it throughout.
Host content for Swift will go into this directory, to be installed later.
|
@swift-ci please test |
etcwilde
reviewed
Nov 30, 2022
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test Linux |
|
@swift-ci please clean test macOS |
…faces." This reverts commit 2f1be83.
|
@swift-ci please test |
|
@swift-ci please test |
|
I'm turning off building with library evolution for the moment, because it's triggering some surprising failures in parsing |
|
@swift-ci please test |
ahoppen
reviewed
Dec 1, 2022
| set(module_dir ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}) | ||
| set(module_base "${module_dir}/${name}.swiftmodule") | ||
| set(module_file "${module_base}/${SWIFT_MODULE_TRIPLE}.swiftmodule") | ||
| set(module_interface_file "${module_base}/${SWIFT_MODULE_TRIPLE}.swiftinterface") |
There was a problem hiding this comment.
I think we don’t use module_interface_file anywhere. Is that intentional?
There was a problem hiding this comment.
It's a vestige of the failed attempt to enable library evolution. There's a potential miscompile in the very old Swift on CI.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the build and installation of all swift-syntax modules in a few ways:
add_swift_host_libraryto eliminate a lot of copy-and-paste.BUILD_SHARED_LIBSrather than forcing static builds; the compiler will start building these as dynamic libraries.swiftmoduledirectorieslib/swift/hostin the toolchain, so other clients can use them