Emit error for unterminated block comment #1619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/unterminated-block-comment
branch
from
b75a739 to
6c1b79d
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/unterminated-block-comment
branch
from
6c1b79d to
f30bce1
Compare
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
|
@swift-ci Please test Windows |
|
@swift-ci Please test macOS |
ahoppen
force-pushed
the
ahoppen/unterminated-block-comment
branch
from
f30bce1 to
14e81f1
Compare
|
@swift-ci Please test macOS |
bnbarham
approved these changes
May 1, 2023
|
@swift-ci Please test Linux |
|
@swift-ci Please test |
hamishknight
approved these changes
May 2, 2023
Fixes swiftlang#1468 Resolves rdar://107424615
ahoppen
force-pushed
the
ahoppen/unterminated-block-comment
branch
from
14e81f1 to
e47d395
Compare
|
@swift-ci Please test |
|
@swift-ci please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing this, also sort a few enumerations of the lexer diagnostics.
Fixes #1468
Resolves rdar://107424615