Deprecate manipulation functions on SyntaxCollection #1879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
DougGregor
approved these changes
Jul 6, 2023
Instead of re-inventing the wheel and providing hand-written `appending` etc. functions on `SyntaxCollection`, clients should use the methods on `Array` to manipulate the elements of a `SyntaxCollection` and create a new collection node once the manipulation is done.
ahoppen
force-pushed
the
ahoppen/syntax-collection-manipulation
branch
from
3331e70 to
85e2d3a
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of re-inventing the wheel and providing hand-written
appendingetc. functions onSyntaxCollection, clients should use the methods onArrayto manipulate the elements of aSyntaxCollectionand create a new collection node once the manipulation is done.