Renamed file to fileTree in SourceLocationConverter #1991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Thanks @natikgadzhi, these changes look perfect. The formatting is also good, format.py probably through you off because you have swift-format installed on your system. I’m adding a paragraph about it to CONTRIBUTING.md: https://github.com/apple/swift-syntax/pull/1993/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055R26
|
I’ll run CI and if it passes, I’ll merge the PR. @swift-ci Please test |
|
Yep, I have swift-format from brew — might not be the latest main. |
|
@ahoppen thank you for such a quick review! 👏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request closes #1974. My first PR in swift-syntax, just learning my way around things.
Modifications
This pull request renames
filetofileNameinSourceLocataionConverterso the intent behind it is more readable and obvious. It also provides the new initializer.init(fileName:tree:)and deprecates the existing.init(file:tree:).TODO
filetofileName./format.py.