Skip to content

Mark toolchain parameter as required #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2020
Merged

Mark toolchain parameter as required #201

merged 1 commit into from
Jan 31, 2020

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jan 29, 2020

If the toolchain was not provided, build-script would crash. Hence, we should mark it as required.

@ahoppen
Mark toolchain parameter as required
33d2c9e 
If the toolchain was not provided, build-script would crash. Hence, we
should mark it as required.
@ahoppen ahoppen requested a review from Rostepher January 29, 2020 18:20
@ahoppen
Copy link
Member Author

ahoppen commented Jan 29, 2020

@swift-ci Please test

@ahoppen ahoppen requested a review from akyrtzi January 29, 2020 21:12
@shahmishal
Copy link
Member

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 33d2c9e

@shahmishal
Copy link
Member

@swift-ci test Linux

@ahoppen ahoppen merged commit 1f211ba into swiftlang:master Jan 31, 2020
@ahoppen ahoppen deleted the toolchain-required branch January 14, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akyrtzi akyrtzi akyrtzi approved these changes

@Rostepher Rostepher Awaiting requested review from Rostepher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahoppen @shahmishal @swift-ci @akyrtzi