Improve compatibility layer for KeyPathPropertyComponentSyntax
#2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rename of `identifier` -> `declName` was not correct in `KeyPathPropertyComponentSyntax` because we also chagned its type from `TokenSyntax` to `DeclReferenceExprSyntax`. Instead, provide two hand-written compatibility properties that transparently access the `DeclReferenceExprSyntax`.
|
@swift-ci Please test |
bnbarham
approved these changes
Aug 11, 2023
|
All of the other places were the arguments of underscored attributes, which I don’t expect many clients to use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rename of
identifier->declNamewas not correct inKeyPathPropertyComponentSyntaxbecause we also chagned its type fromTokenSyntaxtoDeclReferenceExprSyntax.Instead, provide two hand-written compatibility properties that transparently access the
DeclReferenceExprSyntax.