Fix issue that caused errors thrown from macro expansion to show up twice in MacroSystem #2115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test Linux |
1 similar comment
|
@swift-ci Please test Linux |
bnbarham
approved these changes
Sep 1, 2023
| case failure | ||
|
|
||
| /// The node that should be expanded was not a macro known to the macro system. | ||
| case notAMacro |
…wice in MacroSystem If the macro expansion of a freestanding expression macro throws an error, `expandCodeBlockItem` returned `nil` while adding the thrown error to the macro expansion context. `visit(_:CodeBlockItemListSyntax).addResult` took the `nil` return value as an indicator that the macro wasn’t expanded because its macro definition wasn’t found and ended up calling the expansion again in ```swift // Recurse on the child node newItems.append(visit(node)) ``` Change the return value of `expandCodeBlockItem` to an enum that indicates whether the macro was not found or if the expansion failed. If the macro was found but the expansion threw an error, we just just retain the macro as-is without calling into `visit` again. Fixes swiftlang#2111 rdar://114592410
ahoppen
force-pushed
the
ahoppen/multiple-errors
branch
from
2c48690 to
c32dca9
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the macro expansion of a freestanding expression macro throws an error,
expandCodeBlockItemreturnednilwhile adding the thrown error to the macro expansion context.visit(_:CodeBlockItemListSyntax).addResulttook thenilreturn value as an indicator that the macro wasn’t expanded because its macro definition wasn’t found and ended up calling the expansion again inChange the return value of
expandCodeBlockItemto an enum that indicates whether the macro was not found or if the expansion failed. If the macro was found but the expansion threw an error, we just just retain the macro as-is without calling intovisitagain.Fixes #2111
rdar://114592410